Skip to content

feat(cockpit): add preconfigured_alert_ids field and deprecate enable_managed_alerts #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

feat(cockpit): add preconfigured_alert_ids field and deprecate enable_managed_alerts #3470

wants to merge 27 commits into from

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Nov 21, 2025

…

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 298 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.76%. Comparing base (8dcb144) to head (1812917).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/cockpit/alert_manager.go 0.00% 157 Missing ⚠️
...ervices/cockpit/preconfigured_alert_data_source.go 0.00% 134 Missing ⚠️
internal/services/cockpit/helpers_cockpit.go 0.00% 6 Missing ⚠️
provider/sdkv2.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #3470      +/-   ##
=========================================
- Coverage    1.77%   1.76%   -0.02%     
=========================================
  Files         405     406       +1     
  Lines       44273   44532     +259     
=========================================
- Hits          786     784       -2     
- Misses      43400   43660     +260     
- Partials       87      88       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/cockpit-preconfigured-alerts branch 2 times, most recently from 573c472 to 9046217 Compare November 24, 2025 06:16
@github-actions github-actions bot added k8s Kubernetes Kapsule issues, bugs and feature requests file Filesystem issues, bugs and feature requests labels Nov 24, 2025
@jremy42 jremy42 marked this pull request as ready for review November 28, 2025 09:10
@jremy42 jremy42 requested review from a team and remyleone as code owners November 28, 2025 09:10
@jremy42 jremy42 added observability Cockpit observability issues, bugs and feature requests and removed k8s Kubernetes Kapsule issues, bugs and feature requests file Filesystem issues, bugs and feature requests labels Nov 28, 2025
jremy42 added 19 commits December 1, 2025 10:13
@jremy42
feat(cockpit): add preconfigured_alert_ids field and deprecate enable…
5bba79d 
…_managed_alerts
@jremy42
feat(cockpit): add default_preconfigured_alert_ids field to track API…
1629131 
… defaults
@jremy42
fix(cockpit): handle permission errors gracefully in alert manager read
746ee73
@jremy42
feat: compress VCR cassettes for cockpit alert manager tests
f337766
@jremy42
feat: integrate SDK waiters for preconfigured alerts and remove obsol…
f5bf9f2 
…ete comments
@jremy42
chore: update go.mod and go.sum for SDK waiters integration
5041e0b
@jremy42
feat: align preconfigured alerts diff with user selections
4c439a1
@jremy42
docs: fix cockpit preconfigured alert Markdown indentation
7ab4768
@jremy42
chore: gofmt cockpit alert manager and data source
5bd0482
@jremy42
chore: satisfy golangci-lint for cockpit updates
093abed
@jremy42
chore: fix lint spacing in alert manager test
e9d719d
@jremy42
chore: fix cockpit alert manager cassette validation
01ec8df
@jremy42
docs: remove trailing blank line in cockpit migration guide
4c27276
@jremy42
docs: drop trailing newline in cockpit migration guide
1593b32
@jremy42
docs: add newline at EOF for cockpit guide
3a14058
@jremy42
feat: align cockpit migration guide formatting
a269696
@jremy42
feat: restore legacy enable_managed_alerts behavior
78eb78d
@jremy42
chore: run go mod tidy
d5dea0e
@jremy42
feat: fix alert_manager to use proper ID parsing helpers
7ff1083
@jremy42 jremy42 force-pushed the feat/cockpit-preconfigured-alerts branch from a9b8e33 to 44b0dfb Compare December 1, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

observability Cockpit observability issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jremy42 @codecov-commenter